git.lucas.co / cce-system-interface
system settings
git clone https://git.lucas.co/cce-system-interface.git

commitfc986a07903277a59e4097087d64854bc952a944
parent3bed8a4f40
authorLucas Galante <[email protected]>
date2026-07-10 09:41
chore: drop draws_own_popovers — the engine popup path is deleted (Phase 6x)

The hook gated the engine's render-only xdg popup, which no longer exists;
popovers and the context menu already draw into the frame (6t).

Co-Authored-By: Claude Fable 5 <[email protected]>

 src/main.rs     | 6 ------
 src/renderer.rs | 8 ++++----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/main.rs b/src/main.rs
index cc1bc3e..4b00615 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -302,12 +302,6 @@ impl cce_ui::engine::Application for SystemInterface {
         Some(&self.ui_context)
     }
 
-    fn draws_own_popovers(&self) -> bool {
-        // Popovers + context menu draw into the display list (rebuild_layout) — the engine
-        // must not spawn its render-only xdg popup.
-        true
-    }
-
     fn clear_color(&self) -> [f32; 4] {
         [0.039, 0.102, 0.055, 1.0]
     }
diff --git a/src/renderer.rs b/src/renderer.rs
index c93dc06..9f3dbda 100644
--- a/src/renderer.rs
+++ b/src/renderer.rs
@@ -564,12 +564,12 @@ impl SystemInterface {
             texts.push((t.clone(), *size, *x, *y, *tc, font_opt.clone(), *bounds));
         }
 
-        // Popovers + context menu draw INTO the frame (Phase 6t): the same collector the
-        // engine's xdg popup used, but emitted on top of the whole window — the dropdown's
-        // open-upward popover finally renders where it hit-tests. Kept out of
+        // Popovers + context menu draw INTO the frame (Phase 6t; the engine xdg popup no
+        // longer exists) — emitted on top of the whole window, so the dropdown's
+        // open-upward popover renders where it hit-tests. Kept out of
         // widgets/texts so the wheel fast-path can't scroll them; dl-text occlusion comes
         // from the ui_context popover registration (and the engine's context-menu overlay
-        // rect under draws_own_popovers).
+        // rect).
         let mut popover_pc = PageContent::new();
         {
             // Chrome popover (the page dropdown) is in window coords; page-widget popovers