git.lucas.co / cce-compositor
Wayland compositor (wlroots)
git clone https://git.lucas.co/cce-compositor.git

commitd59070053a33631806ee30451f688e20d3915eb3
parente18dd2527e
authorIsaac Freund <[email protected]>
date2021-03-28 13:55
render: don't schedule new frame on output commit failure

This reverts commit c457b12cf3c2040f37f9322095a20ad16a15b337.

This attempted workaround seems to work fine if the output commit only
fails with EBUSY, but enters an infinite loop otherwise.

 river/render.zig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/river/render.zig b/river/render.zig
index 204d760..1878c6b 100644
--- a/river/render.zig
+++ b/river/render.zig
@@ -142,10 +142,9 @@ pub fn renderOutput(output: *Output) void {
         output.wlr_output.setDamage(&damage);
     }
 
-    output.wlr_output.commit() catch {
-        log.err("output commit failed for {}, retrying", .{std.mem.spanZ(&output.wlr_output.name)});
-        output.wlr_output.scheduleFrame();
-    };
+    // TODO: handle failure
+    output.wlr_output.commit() catch
+        log.err("output commit failed for {}", .{output.wlr_output.name});
 }
 
 fn renderFilter(view: *View, filter_tags: u32) bool {