git.lucas.co / cce-compositor
Wayland compositor (wlroots)
git clone https://git.lucas.co/cce-compositor.git

commitce00030762f88a12ae2119fc5de997d5c18f1cb9
parent75cba1a808
authorIsaac Freund <[email protected]>
date2026-02-26 16:31
Revert "Xwayland: ensure all state sent for new windows"

Apparently this made things worse in practice, go figure. Let's not make
Xwayland changes based on presumed knowledge of how X11 clients
should/will behave in practice. Instead, we must test and observe.

This reverts commit d755f6394b630a49d141039dffc64331a8ff2b3a.

 river/XwaylandWindow.zig | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/river/XwaylandWindow.zig b/river/XwaylandWindow.zig
index 0870d75..1e17698 100644
--- a/river/XwaylandWindow.zig
+++ b/river/XwaylandWindow.zig
@@ -75,23 +75,6 @@ pub fn create(xsurface: *wlr.XwaylandSurface) error{OutOfMemory}!void {
     xsurface.events.request_fullscreen.add(&xwindow.request_fullscreen);
     xsurface.events.request_minimize.add(&xwindow.request_minimize);
 
-    // When an override redirect window is converted to a normal Xwayland window
-    // we need to synchronize state which may have changed.
-    if (xwindow.xsurface.decorations.no_border or xwindow.xsurface.decorations.no_title) {
-        xwindow.window.wm_scheduled.decoration_hint = .prefers_csd;
-    } else {
-        xwindow.window.wm_scheduled.decoration_hint = .prefers_ssd;
-    }
-    if (xwindow.xsurface.fullscreen) {
-        xwindow.window.wm_scheduled.fullscreen_requested = .{ .fullscreen = null };
-    }
-    if (xwindow.xsurface.maximized_vert or xwindow.xsurface.maximized_horz) {
-        xwindow.window.wm_scheduled.maximize_requested = .maximize;
-    }
-    if (xwindow.xsurface.minimized) {
-        xwindow.window.wm_scheduled.minimize_requested = true;
-    }
-
     if (xsurface.surface) |surface| {
         handleAssociate(&xwindow.associate);
         if (surface.mapped) {