git.lucas.co / cce-compositor
Wayland compositor (wlroots)
git clone https://git.lucas.co/cce-compositor.git

commit63eb7acba3e20a779d3dd24da2006fde251d97e2
parent98ecef729f
authorIsaac Freund <[email protected]>
date2024-06-12 14:19
xkb-keybinds: check modifiers only on key press

 protocol/river-xkb-keybinds-v1.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/protocol/river-xkb-keybinds-v1.xml b/protocol/river-xkb-keybinds-v1.xml
index f4ac2ce..91dac0a 100644
--- a/protocol/river-xkb-keybinds-v1.xml
+++ b/protocol/river-xkb-keybinds-v1.xml
@@ -211,6 +211,16 @@
       <description summary="set modifiers required to trigger keybind">
         Set the modifiers that must be held in order to trigger the keybind.
 
+        Modifiers are always checked on key press regardless of the trigger
+        configured with the set_trigger request. For example, the following
+        series of physical key events would trigger a keybind with keysym "x",
+        modifiers "shift", and trigger "release":
+
+        1. shift key pressed
+        2. x key pressed (currently pressed modifiers checked here)
+        3. shift key released
+        4. x key released (trigger event sent to keybind object here)
+
         If this request is not made before the enable request no modifiers will
         be required (equivalent to passing none).