git.lucas.co / cce-compositor
Wayland compositor (wlroots)
git clone https://git.lucas.co/cce-compositor.git

commit0a88539ced961e1fa73b6a72396b8cc101029ab5
parentdc620377f4
authorIsaac Freund <[email protected]>
date2023-03-04 20:52
river: clean up some uneeded TODOs

 river/Cursor.zig       | 1 -
 river/InputConfig.zig  | 5 -----
 river/Root.zig         | 2 --
 river/XwaylandView.zig | 1 -
 4 files changed, 9 deletions(-)

diff --git a/river/Cursor.zig b/river/Cursor.zig
index 1f62fa2..82768ec 100644
--- a/river/Cursor.zig
+++ b/river/Cursor.zig
@@ -224,7 +224,6 @@ pub fn init(self: *Self, seat: *Seat) !void {
     wlr_cursor.events.pinch_end.add(&self.pinch_end);
     seat.wlr_seat.events.request_set_cursor.add(&self.request_set_cursor);
 
-    // TODO(wlroots) handle the cancel event, blocked on wlroots 0.16.0
     wlr_cursor.events.touch_up.add(&self.touch_up);
     wlr_cursor.events.touch_down.add(&self.touch_down);
     wlr_cursor.events.touch_motion.add(&self.touch_motion);
diff --git a/river/InputConfig.zig b/river/InputConfig.zig
index 13432d4..9be00ae 100644
--- a/river/InputConfig.zig
+++ b/river/InputConfig.zig
@@ -29,11 +29,6 @@ const util = @import("util.zig");
 
 const InputDevice = @import("InputDevice.zig");
 
-// TODO - keyboards
-//      - mapping to output / region
-//      - calibration matrices
-//      - scroll factor
-
 pub const EventState = enum {
     enabled,
     disabled,
diff --git a/river/Root.zig b/river/Root.zig
index 49aa9db..cbbfd21 100644
--- a/river/Root.zig
+++ b/river/Root.zig
@@ -740,8 +740,6 @@ fn processOutputConfig(
 }
 
 fn currentOutputConfig(self: *Self) !*wlr.OutputConfigurationV1 {
-    // TODO there no real reason this needs to allocate memory every time it is called.
-    // consider improving this wlroots api or reimplementing in zig-wlroots/river.
     const config = try wlr.OutputConfigurationV1.create();
     // this destroys all associated config heads as well
     errdefer config.destroy();
diff --git a/river/XwaylandView.zig b/river/XwaylandView.zig
index b715abd..3b1b83a 100644
--- a/river/XwaylandView.zig
+++ b/river/XwaylandView.zig
@@ -115,7 +115,6 @@ pub fn configure(self: Self) bool {
 }
 
 pub fn rootSurface(self: Self) *wlr.Surface {
-    // TODO This is probably not OK, understand when xwayland surfaces can be null.
     return self.xwayland_surface.surface.?;
 }